Re: [PATCH v8 6/8] submodule: refactor show_submodule_summary with helper function

From: Jacob Keller <jacob.keller@gmail.com>
Date: Aug 19, 2016, 20:33 UTC
Message-ID: <CA+P7+xpkNa6Kj3WFKVWS_dmpn76dGoKYFUMvA4NSO5viFsnWJw@mail.gmail.com>
In-Reply-To: <xmqqk2fc1p8r.fsf@gitster.mtv.corp.google.com>

On Fri, Aug 19, 2016 at 1:24 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> And probably merge_bases also leaks here.
>
> It is not cheap to compute merge bases, but show_submodule_summary()
> makes two calls to get_merge_bases(), one in show_submodule_header()
> and then another inside prepare_submodule_summary() to compute
> exactly the same set of merge bases.  We somehow need to reduce it
> to just one.
>

I can make show_submodule_headers take another parameter which we pass, and then pass that into prepare_submodule_summary...?

Thanks, Jake

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.