Re: [PATCH 3/4] filter-branch: fix --prune-empty on parentless commits
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Mar 2, 2017, 23:28 UTC
- Message-ID
- <CA+P7+xpBA+JQbH1=yKL01-rL9z0GKtY1pxBa8feXV41ebOpAPQ@mail.gmail.com>
- In-Reply-To
- <xmqqshmvbhe5.fsf@gitster.mtv.corp.google.com>
On Thu, Mar 2, 2017 at 11:36 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 17 quoted lines
> "Devin J. Pohly" <djpohly@gmail.com> writes: > >> I think your point is interesting too, though. If a commit is also >> TREESAME to its parent(s?) in the _pre-filtered_ branch, it seems >> reasonable that someone might want to leave it in the filtered branch as >> an empty commit while pruning empt*ied* commits. I would imagine that >> as another option (--prune-newly-empty?). > > I was hoping to hear from others who may care about filter-branch to > comment on this topic to help me decide, but I haven't heard > anything, so here is my tentative thinking. > > I am leaning to: > > * Take your series as-is, which would mean --prune-empty will > change the behaviour to unconditionally lose the empty root. >
This new behavior is how I expected prune-empty to behave, so seeing that it did not already behave this way was surprising.
Thanks, Jake