git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] diff: fix --relative without arguments

From
Jacob Keller <jacob.keller@gmail.com>
Date
Dec 7, 2017, 19:01 UTC
Message-ID
<CA+P7+xpAFJcvcQ9PN5ZsnQxf8GpSG2yYKSYEg5wHebyCLtvdsw@mail.gmail.com>
In-Reply-To
<xmqq4lp2ftjt.fsf@gitster.mtv.corp.google.com>
On Thu, Dec 7, 2017 at 7:26 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
>> From: Jacob Keller <jacob.keller@gmail.com>
>>
>> Recently, commit f7923a5ece00 ("diff: use skip_to_optional_val()",
>> 2017-12-04) changed how we parsed some diff options, preferring
>> skip_to_optional_val instead of a more complex skip_prefix() setup.
>
> I'd expect a moral equivalent of this squashed in when Christian
> rerolls the skip-to-optional-val series (with helped-by: attribution
> to you, probably).  It does not make much sense to leave the initial
> breakage like this one in the history.
>
> Thanks.
Quite correct. I'll be sending a patch with just new tests shortly.

Thanks, Jake

Previous: Junio C Hamano
Message 3 of 3 in “diff: fix --relative without arguments”
  1. diff: fix --relative without argumentsJacob Keller, Dec 7, 2017
  2. Junio C HamanoDec 7, 2017
  3. Jacob KellerDec 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.