Re: [PATCH] more oideq/hasheq conversions

From: Jacob Keller <jacob.keller@gmail.com>
Date: Oct 2, 2018, 23:46 UTC
Message-ID: <CA+P7+xp6B4K-bHnSV1npL-1pV30jENFyPKDmCmzEuRZKFK=jQg@mail.gmail.com>
In-Reply-To: <20181002211921.GA3322@sigill.intra.peff.net>

On Tue, Oct 2, 2018 at 2:19 PM Jeff King <peff@peff.net> wrote:

Show 13 quoted lines

>
> We added faster equality-comparison functions for hashes in
> 14438c4497 (introduce hasheq() and oideq(), 2018-08-28). A
> few topics were in-flight at the time, and can now be
> converted. This covers all spots found by "make coccicheck"
> in master (the coccicheck results were tweaked by hand for
> style).
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Jake: I was surprised that this was not a "patch 2" on top of your
> earlier coccicheck patch. Apologies if you were planning to send it out.
>

Nope, I hadn't gotten around to this yet, thanks!

The conversions also look good to me :)

Regards, Jake