git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] worktree refs: fix case sensitivity for 'head'

From
Jacob Keller <jacob.keller@gmail.com>
Date
Dec 14, 2018, 06:49 UTC
Message-ID
<CA+P7+xonxvfuhw4W+FUL87We8CaOwxsndFkN5bcgBhdsnZ5QAg@mail.gmail.com>
In-Reply-To
<CANoM8SWQTAEYGiUC9PnWi8u9oAJYPcyiE5+5usoRvR7Vw2z0JA@mail.gmail.com>
On Thu, Dec 13, 2018 at 1:16 PM Mike Rappazzo <rappazzo@gmail.com> wrote:
Show 16 quoted lines
>
> On Thu, Dec 13, 2018 at 3:48 PM Stefan Beller <sbeller@google.com> wrote:
> >
> > > > The current situation is definitely a problem.  If I am in a worktree,
> > > > using "head" should be the same as "HEAD".
> >
> > By any chance, is your file system case insensitive?
> > That is usually the source of confusion for these discussions.
>
> This behavior is the same for MacOS (High Sierra) and Windows 7.  I
> assume other derivatives of those act the same.
>
> On CentOS "head" is an ambiguous ref.  If Windows and Mac resulted in
> an ambiguous ref, that would also be OK, but as it is now, they return
> the result of "HEAD" on the primary worktree.
>

Because refs are *not* case sensitive, and we know that "HEAD" should be per-worktree, it gets checked in the per-worktree refs section. But lowercase head is known to not be a per-worktree ref, so we then ask the main worktree about head. Since you happen to be on a case insensitive file system, it then finds refs/HEAD in the main refs worktree, and returns that.

I don't understand why the CentOS shows it as ambiguous, unless you actually happen to have a ref named head. (possibly a branch?)

I suspect we could improve things by attempting to figure out if our file system is case insensitive and warn users. However, I recall patches which tried this, and no suitable method was found. Partly because it's not just "case" that is the only problem. There might be things like unicode characters which don't get properly encoded, etc.

The best solution would be to get a non-filesystem backed ref storage working that could be used in place of the filesystem.

Thanks, Jake

> >
> > Maybe in worktree code we have a spillover between path
> > resolution and ref namespace?
Previous: brian m. carlsonNext: Duy Nguyen
Message 9 of 18 in “worktree refs: fix case sensitivity for 'head'”
  1. 0/1 worktree refs: fix case sensitivity for 'head'Michael Rappazzo via GitGitGadget, Dec 13, 2018
  2. 1/1 worktree refs: fix case sensitivity for 'head'Michael Rappazzo via GitGitGadget, Dec 13, 2018
  3. Duy NguyenDec 13, 2018
  4. Mike RappazzoDec 13, 2018
  5. Duy NguyenDec 13, 2018
  6. Stefan BellerDec 13, 2018
  7. Mike RappazzoDec 13, 2018
  8. brian m. carlsonDec 14, 2018
  9. Jacob KellerDec 14, 2018
  10. Duy NguyenDec 14, 2018
  11. Jacob KellerDec 14, 2018
  12. Duy NguyenDec 14, 2018
  13. Duy NguyenDec 14, 2018
  14. Jacob KellerDec 14, 2018
  15. Jacob KellerDec 14, 2018
  16. Mike RappazzoDec 13, 2018
  17. Junio C HamanoDec 14, 2018
  18. Johannes SchindelinDec 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.