git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 3/6] note: extract parse_notes_merge_strategy to notes-utils

From
Jacob Keller <jacob.keller@gmail.com>
Date
Aug 18, 2015, 00:15 UTC
Message-ID
<CA+P7+xohUHsJfxjKMTkOfmAmRNPJ5S-z4HgtcGZB0VmYDf5Oyg@mail.gmail.com>
In-Reply-To
<xmqqbne5bkx7.fsf@gitster.dls.corp.google.com>
On Mon, Aug 17, 2015 at 3:38 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> Jacob Keller <jacob.e.keller@intel.com> writes:
>
>> From: Jacob Keller <jacob.keller@gmail.com>
>>
>> Combining rewrite and notes-merge functionality has been left as an
>> exercise for a future contributor.
>
> This comment is probably unnecessary; we haven't even established if
> such a combination is desirable AFAICT in the discussion.
>
> The patch itself looks very straightforward and obviously good.
>
> Thanks.
>

Feel free to fix that up if you want. Probably easier than me respinning the whole series.

Regards, Jake

Previous: Junio C HamanoNext: Jacob Keller
Message 6 of 10 in “implement notes.mergeStrategy”
  1. 0/6 implement notes.mergeStrategyJacob Keller, Aug 17, 2015
  2. 1/6 notes: document cat_sort_uniq rewriteModeJacob Keller, Aug 17, 2015
  3. 2/6 notes: extract enum notes_merge_strategy to notes-utils.hJacob Keller, Aug 17, 2015
  4. 3/6 note: extract parse_notes_merge_strategy to notes-utilsJacob Keller, Aug 17, 2015
  5. Junio C HamanoAug 17, 2015
  6. Jacob KellerAug 18, 2015
  7. 4/6 notes: add tests for --commit/--abort/--strategy exclusivityJacob Keller, Aug 17, 2015
  8. 5/6 notes: add notes.mergeStrategy option to select default strategyJacob Keller, Aug 17, 2015
  9. 6/6 notes: teach git-notes about notes.<name>.mergeStrategy optionJacob Keller, Aug 17, 2015
  10. Junio C HamanoAug 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.