git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove --no-gui option from difftool usage string

From
Jacob Keller <jacob.keller@gmail.com>
Date
Feb 4, 2017, 05:58 UTC
Message-ID
<CA+P7+xoXWP=Cuqw3Pa1sFCChiw6wbNTEpvNm3WDuBHQPc_OjnA@mail.gmail.com>
In-Reply-To
<20170204025617.GA9221@arch-attack.localdomain>
On Fri, Feb 3, 2017 at 6:56 PM, Denton Liu <liu.denton@gmail.com> wrote:
Show 27 quoted lines
> The --no-gui option not documented in the manpage, nor is it actually
> used in the source code. This change removes it from the usage help
> that's printed.
>
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
>  git-difftool.perl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/git-difftool.perl b/git-difftool.perl
> index a5790d03a..657d5622d 100755
> --- a/git-difftool.perl
> +++ b/git-difftool.perl
> @@ -29,8 +29,8 @@ sub usage
>         print << 'USAGE';
>  usage: git difftool [-t|--tool=<tool>] [--tool-help]
>                      [-x|--extcmd=<cmd>]
> -                    [-g|--gui] [--no-gui]
> -                    [--prompt] [-y|--no-prompt]
> +                    [-g|--gui] [--prompt]
> +                    [-y|--no-prompt]
>                      [-d|--dir-diff]
>                      ['git diff' options]
>  USAGE
> --
> 2.11.0
>

Aren't "--no-foo" options automatically created for booleans when using our option parsing code?

Thanks, Jake

Previous: Denton LiuNext: Denton Liu
Message 2 of 12 in “Remove --no-gui option from difftool usage string”
  1. Remove --no-gui option from difftool usage stringDenton Liu, Feb 4, 2017
  2. Jacob KellerFeb 4, 2017
  3. Denton LiuFeb 4, 2017
  4. David AguilarFeb 5, 2017
  5. [BUG] was: Re: [PATCH] Remove --no-gui option from difftool usage stringDavid Aguilar, Feb 5, 2017
  6. difftool: fix bug when printing usageDavid Aguilar, Feb 5, 2017
  7. Johannes SchindelinFeb 6, 2017
  8. Junio C HamanoFeb 6, 2017
  9. Johannes SchindelinFeb 7, 2017
  10. Junio C HamanoFeb 7, 2017
  11. Junio C HamanoFeb 7, 2017
  12. Johannes SchindelinFeb 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.