Re: [v4] refspec: add support for negative refspecs

From: Jacob Keller <jacob.keller@gmail.com>
Date: Sep 30, 2020, 22:00 UTC
Message-ID: <CA+P7+xoTXrjik5fqSN1Qndek8hyaSdTtn=88hRnxLCmRMhdQyg@mail.gmail.com>
In-Reply-To: <CAPig+cQUeQV0=LDQ_tY43k6z7km4X6Fm9JJVPUBoG=wY3gxDfw@mail.gmail.com>

On Wed, Sep 30, 2020 at 2:34 PM Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 10 quoted lines

>
> On Wed, Sep 30, 2020 at 5:26 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
> > Changes since v3
> > * removed the ?: usage (for real this time)
> >
> > +               /* Note the reversal of src and dst */
> > +               if (refspec->pattern) {
> > +                       const char *key = refspec->dst ?: refspec->src;
>
> Blorp.

.... I am very confused....   I made this change...

$git diff doesn't show anything...

Oh.. wooooops. git status has it as staged but not applied..

Sigh. I sent another round.