Re: [PATCH] credential: let empty credential specs reset helper list

From: Jacob Keller <jacob.keller@gmail.com>
Date: Feb 26, 2016, 22:13 UTC
Message-ID: <CA+P7+xoSPmvZp-3rgDc+JjuDKEdNvayPMM4azb2UgDaSk_gJ7g@mail.gmail.com>
In-Reply-To: <xmqqk2lrjmff.fsf@gitster.mtv.corp.google.com>

On Fri, Feb 26, 2016 at 11:34 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 7 quoted lines

>
> Of course, the code in the configuration subsystem for updated
> version of Git needs to become aware of the new syntax, and those
> that deal with the multi-value variables need custom code, which is
> similar to the way you special cased an empty value in the above
> patch, so I am not sure how much this would help.
>

For most cases, I think the previous approach of setting to empty string makes sense and is more easilly intuitive, but would only work for those values which the empty string has no valid meaning.

I would think either approach here is fine, and i think *most* cases of multivariable configuration don't need to be cleared from within a configuration file but only on the command line would be acceptable.

If we go this route I would prefer "-c !<config>" vs "-c <namespace>.!<config>"

Thanks, Jake