git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: exec leaks GIT_DIR to environment

From
Jacob Keller <jacob.keller@gmail.com>
Date
Oct 30, 2017, 06:26 UTC
Message-ID
<CA+P7+xo5UgUPQCYU-LaXn+HZZ1qe++KOevTMh2C1sgnzK0SAQA@mail.gmail.com>
In-Reply-To
<xmqqo9op71d8.fsf@gitster.mtv.corp.google.com>
On Sun, Oct 29, 2017 at 8:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Jacob Keller <jacob.keller@gmail.com> writes:
>
>> I am pretty confident we can fix it....
>
> I am sure we can eventually, but 3 hours is not enough soak time.
>
> I am inclined to leave the fix for 2.15.1/2.16.0 instead of delaying
> the release by 10 more days.

That's fair. I'm not even sure it was introduced since the last release (I tried 2.12, but not 2.13 or 2.14 manually). Thus, it likely wasn't noticed for at least a release, meaning it's less important (to me at least) that we provide a fix immediately, since it went unnoticed this long, likely that means few people will be impacted.

As far as I can tell, you'd only be impacted if you attempt to run a git command from within a sub directory inside of an exec statement. Is there some place we can list it as a known bug in case someone else runs into it?

Regards, Jake

Previous: Junio C HamanoNext: Phillip Wood
Message 8 of 12 in “rebase: exec leaks GIT_DIR to environment”
  1. rebase: exec leaks GIT_DIR to environmentJacob Keller, Oct 28, 2017
  2. Johannes SchindelinOct 28, 2017
  3. Jacob KellerOct 28, 2017
  4. Phillip WoodOct 29, 2017
  5. Junio C HamanoOct 30, 2017
  6. Jacob KellerOct 30, 2017
  7. Junio C HamanoOct 30, 2017
  8. Jacob KellerOct 30, 2017
  9. Phillip WoodOct 30, 2017
  10. Johannes SchindelinOct 30, 2017
  11. Jacob KellerOct 31, 2017
  12. Jacob KellerOct 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.