git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 0/1] Fuzzy blame

From
Jacob Keller <jacob.keller@gmail.com>
Date
Mar 26, 2019, 03:07 UTC
Message-ID
<CA+P7+xo-AHmB+Wv0Z+dpgshhmqSLEb41T-JP+NKJD8DAFARA5w@mail.gmail.com>
In-Reply-To
<20190325233516.GB23728@sigill.intra.peff.net>
On Mon, Mar 25, 2019 at 4:37 PM Jeff King <peff@peff.net> wrote:
Show 18 quoted lines
>
> On Mon, Mar 25, 2019 at 11:21:19PM +0000, Michael Platings wrote:
>
> > > I work on a project that needs a major reformatting, and one thing
> > > delaying me was the lack of an ability to ignore commits during blame.
> >
> > I think we understand each other well then - I'm working on a plan to
> > change the variable naming rule in LLVM, and naturally other
> > developers aren't keen on making git blame less useful.
>
> This is sort of a tangent to the thread, but have you looked into tools
> that provide an interactive "re-blame from the parent" operation? I use
> tig for this.  Quite often my blame turns up on some boring line
> (whitespace fixing, minor tweaking of a function interface, etc), and
> then I want to keep digging on the "same" line, as counted by line count
> (but it's OK if it's off by one or two lines, since I'm looking at a
> blame of the whole file).
>

+1 for the usefulness of this approach. It really helps figure things out in a way that doesn't require me to track all "uninteresting" commits, and also works when I *am* trying to find that uninteresting commit too.

Show 10 quoted lines
> Obviously this isn't as automated as saying "ignore commit X, it's just
> variable renaming". But it also eliminates the need to a priori figure
> out all such X that affect the lines you care about. You get an answer,
> your human mind says "nope, that's not interesting", and you press a
> button to dig further.
>
> I think there's room for both solutions to co-exist, but just suggesting
> you to try out the one that's already been implemented if you haven't. ;)
>
> -Peff
That's also my sentiment.

Thanks, Jake

Previous: Jeff KingNext: Michael Platings
Message 8 of 14 in “Fuzzy blame”
  1. 0/1 Fuzzy blamemichael@platin.gs, Mar 24, 2019
  2. 1/1 Fuzzy blamemichael@platin.gs, Mar 24, 2019
  3. Junio C HamanoMar 25, 2019
  4. Michael PlatingsMar 25, 2019
  5. Barret RhodenMar 25, 2019
  6. Michael PlatingsMar 25, 2019
  7. Jeff KingMar 25, 2019
  8. Jacob KellerMar 26, 2019
  9. Michael PlatingsMar 26, 2019
  10. Duy NguyenMar 27, 2019
  11. Michael PlatingsMar 27, 2019
  12. Duy NguyenMar 27, 2019
  13. Barret RhodenApr 3, 2019
  14. Michael PlatingsApr 3, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.