Re: [PATCHv9 4/6] git submodule update: have a dedicated helper for cloning

From: Jacob Keller <jacob.keller@gmail.com>
Date: Feb 10, 2016, 02:26 UTC
Message-ID: <CA+P7+xo=GK79DRvV6ZYds3wx6bayoWHC49UmkWL20=xo=jpS2g@mail.gmail.com>
In-Reply-To: <1455051274-15256-5-git-send-email-sbeller@google.com>

On Tue, Feb 9, 2016 at 12:54 PM, Stefan Beller <sbeller@google.com> wrote:

Show 15 quoted lines

> This introduces a new helper function in git submodule--helper
> which takes care of cloning all submodules, which we want to
> parallelize eventually.
>
> Some tests (such as empty URL, update_mode=none) are required in the
> helper to make the decision for cloning. These checks have been
> moved into the C function as well (no need to repeat them in the
> shell script).
>
> As we can only access the stderr channel from within the parallel
> processing engine, we need to reroute the error message for
> specified but initialized submodules to stderr. As it is an error
> message, this should have gone to stderr in the first place, so it
> is a bug fix along the way.
>

I was recently working on a way to make submodule pass some parameters from the parent project into the submodule project (specifically settings regarding authentication such as using an authentication helper), and I think this would make it easier to do.

Thanks, Jake