Re: About git reporting missing newline for symlinks

From: Erik Cervin Edin <erik@cervined.in>
Date: Oct 13, 2022, 22:01 UTC
Message-ID: <CA+JQ7M_HJf_o=u4DOjdGet5D88kWEDJ+AbwfAWVnx487VSVu=Q@mail.gmail.com>
In-Reply-To: <aead3926-d87b-5fcd-4984-bb690f3fbf4e@iee.email>

On Thu, Oct 13, 2022 at 10:55 PM Philip Oakley <philipoakley@iee.email> wrote:

>
> Pondering on why it is thought of as a warning to be treated as an
> error, maybe the message implies something is missing via the negative
> "No" assertion, rather than simply being informative [1].

Very likely. I imagine most users use diff to view the changes they made without knowledge of the use of diffs in git-apply. Without that background it's more likely to be interpreted as an opinionated comment as opposed to being informative.

> Perhaps swapping out the "No" and instead using something like "\
> Without a newline at end of file" would better convey that it's just
> information about the file's format, and in no way a real problem. Just
> a thought.

That's probably less likely to be read as a warning