Re: [PATCH] http: add support for specifying the SSL version

From: Elia Pinto <gitter.spiros@gmail.com>
Date: Aug 12, 2015, 14:10 UTC
Message-ID: <CA+EOSBn8xXHEXSwZ3sqcs8AaLQfDNw-5bSJSv-gwwGpaH4VW9w@mail.gmail.com>
In-Reply-To: <950187984.739852.1439386399510.JavaMail.zimbra@ensimag.grenoble-inp.fr>

2015-08-12 15:33 GMT+02:00 Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>:

Show 30 quoted lines

> Hello, Elia
>
> Elia Pinto <gitter.spiros@gmail.com> writes:
>> +        if (ssl_version != NULL && *ssl_version) {
>> +                if (!strcmp(ssl_version,"tlsv1")) {
>> +                        sslversion = CURL_SSLVERSION_TLSv1;
>> +                } else if (!strcmp(ssl_version,"sslv2")) {
>> +                        sslversion = CURL_SSLVERSION_SSLv2;
>> +                } else if (!strcmp(ssl_version,"sslv3")) {
>> +                        sslversion = CURL_SSLVERSION_SSLv3;
>> +#if LIBCURL_VERSION_NUM >= 0x072200
>> +                } else if (!strcmp(ssl_version,"tlsv1.0")) {
>> +                        sslversion = CURL_SSLVERSION_TLSv1_0;
>> +                } else if (!strcmp(ssl_version,"tlsv1.1")) {
>> +                        sslversion = CURL_SSLVERSION_TLSv1_1;
>> +                } else if (!strcmp(ssl_version,"tlsv1.2")) {
>> +                        sslversion = CURL_SSLVERSION_TLSv1_2;
>> +                } else {
>> +                        warning("unsupported ssl version %s : using default",
>> +                        ssl_version);
>> +#endif
>> +                }
>> +        }
>
> I'm curious about what would happen should 'sslVersion' be set to
> 'tlsv1.0' (or a value that doesn't belong to the possible values) and
> 'LIBCURL_VERSION_NUM' be inferior to '0x072200'.
> Since we wouldn't go through any 'if' and would also skip the 'else'
> case, wouldn't we have a silent 'unsupported ssl version: using
> default' ?

You are right. I will resend. Thank you very much

Show 6 quoted lines

>
> So I think that the 'else' case should be outside of the '#if [...]
> #endif'.
>
> Thanks,
> Rémi