Re: [PATCH] configure.ac: Add --with-gcc-warnings configure option

From: Elia Pinto <gitter.spiros@gmail.com>
Date: Mar 6, 2012, 16:08 UTC
Message-ID: <CA+EOSBm6autG8MCe1fWC+8V=Kx6FkAuVdS-SLKUzkmxz-x-qiw@mail.gmail.com>
In-Reply-To: <4F56329E.9050506@gmail.com>

2012/3/6 Stefano Lattarini <stefano.lattarini@gmail.com>:

Show 35 quoted lines

> On 03/06/2012 03:33 PM, Elia Pinto wrote:
>> Introduce a new --with-gcc-warnings configure option
>> using a new autoconf macro that check if the compiler
>> know the option passed or not in a portable way, as
>> it not depends from the gcc version or from the
>> other compiler used.
>>
>> Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
>> ---
>> This is the version 2 of the patch, in which i have
>> slightly changed the commit message for
>> clarify the purpose. To activate the
>> patch is of course necessary to do a autoreconf -vfi after
>> applying the patch.
>>
>>
>>  Makefile      |    2 +-
>>  config.mak.in |    1 +
>>  configure.ac  |  118 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 120 insertions(+), 1 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index be1957a..d0aef0f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -310,7 +310,7 @@ endif
>>
>>  CFLAGS = -g -O2 -Wall
>>  LDFLAGS =
>> -ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS)
>> +ALL_CFLAGS = $(CPPFLAGS) $(CFLAGS) $(AM_CFLAGS)
>>
> Wouldn't it be better to use $(WARN_CFLAGS) here?  It makes the purpose
> of the variable clearer, and don't give the wrong impression that Automake
> is involved (as the 'AM_' prefix might suggest).

Ok, this is derived from the similar patch in popt HEAD and in branch 1.17, for which i use the full autofu. No problem to reroll with your suggestions.

Thanks a lot

Regards

Elia