git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] attr.h: remove duplicate struct definition

From
Elia Pinto <gitter.spiros@gmail.com>
Date
Mar 14, 2022, 10:39 UTC
Message-ID
<CA+EOSBkJtcvKJ1D1hMuWB0EkrGEfP7Dua6gP8MDHehto1r+E3A@mail.gmail.com>
In-Reply-To
<xmqqh781t7ks.fsf@gitster.g>

Il giorno lun 14 mar 2022 alle ore 06:40 Junio C Hamano <gitster@pobox.com> ha scritto:

Show 6 quoted lines
>
> Elia Pinto <gitter.spiros@gmail.com> writes:
>
> > Subject: Re: [PATCH 6/6] attr.h: remove duplicate struct definition
>
> I do not see other 5 from 1/6 thru 5/6 on the list.

I'm sorry. It was my mistake in producing the patch. There are no other cases like this.

Thanks for your patience
Show 38 quoted lines
>
> If this is a leftover bit follow-up to the 5-patch series whose
> cover letter was <20220313195536.224075-1-gitter.spiros@gmail.com>
> we often see such a message
>
>  - with subject numbered as [PATCH 6/5]
>  - as follow-up to the same cover letter.
>
> The patch text looks good, and we can see from the output of
>
>  $ git grep '^struct .*;' \*.h |
>    sort | uniq -c | sort -n | grep -v '^ *1 '
>
> that this is the only duplicated opaque struct declaration in the
> header files.
>
> For now, I'd assume that is the case and queue it on the same topic
> branch as the other five.  Thanks.
>
> > struct index_state is declared more than once.
> >
> > Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
> > ---
> >  attr.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/attr.h b/attr.h
> > index 3732505eda..3fb40cced0 100644
> > --- a/attr.h
> > +++ b/attr.h
> > @@ -121,7 +121,6 @@ struct git_attr;
> >  /* opaque structures used internally for attribute collection */
> >  struct all_attrs_item;
> >  struct attr_stack;
> > -struct index_state;
> >
> >  /*
> >   * Given a string, return the gitattribute object that
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “attr.h: remove duplicate struct definition”
  1. 6/6 attr.h: remove duplicate struct definitionElia Pinto, Mar 14, 2022
  2. Junio C HamanoMar 14, 2022
  3. Elia PintoMar 14, 2022
  4. Junio C HamanoMar 14, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.