git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] stash: add test for stash create with no files

From
Joel Teichroeb <joel@teichroeb.net>
Date
Aug 19, 2017, 21:00 UTC
Message-ID
<CA+CzEk98Tg_jyteZp7SGTchDNjP8FZFvHNXfvisg1XGgsT0vvg@mail.gmail.com>
In-Reply-To
<xmqqpobr8ego.fsf@gitster.mtv.corp.google.com>
Hi Junio,

I was just too lazy to write a cover letter, and thought these would make sense on their own. I'll make sure to include a cover letter next time.

I just ripped them out of my patch series on implementing stash as a builtin[1]. Since I haven't had time, I figured I could at least get the additional tests I wrote into the codebase.

The tests mainly expand coverage of git stash, covering a few critical error cases that didn't have tests.

[1] https://public-inbox.org/git/20170608005535.13080-1-joel@teichroeb.net/
On Sat, Aug 19, 2017 at 1:55 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 14 quoted lines
> I see three patches that add tests, but it is hard to judge them
> without any explanation on what the point of them are.
>
> Are you documenting an existing breakage?  Are you extending test
> coverage for some breakage we recently fixed without adding tests to
> ensure that the fix will stay unbroken?  Are you planning to touch
> the implementation (perhaps to add yet another feature that uses
> some existing code) and adding new tests in advance to avoid breaking
> the existing code?  Some other motivation?
>
> These would have made fine material to write in the cover letter for
> this series.
>
> Thanks.
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 6 in “stash: add test for stash create with no files”
  1. 1/3 stash: add test for stash create with no filesJoel Teichroeb, Aug 19, 2017
  2. 2/3 stash: Add a test for when apply fails during stash branchJoel Teichroeb, Aug 19, 2017
  3. 3/3 stash: add test for stashing in a detached stateJoel Teichroeb, Aug 19, 2017
  4. Junio C HamanoAug 19, 2017
  5. Joel TeichroebAug 19, 2017
  6. Junio C HamanoAug 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.