git/list[1] front-page[2] threads[3] people[4] search[5] about
 

git-core: try_to_follow_renames(): git killed by SIGSEGV

From
Ondrej Pohorelsky <opohorel@redhat.com>
Date
Feb 27, 2020, 12:56 UTC
Message-ID
<CA+B51BFFvn9puia8+kheeWkDfOQ7RYHTcGa74M5aeiTd8-QJXA@mail.gmail.com>
Hi,
there is a SIGSEGV appearing in Fedora[0] with Git 2.24.1

This bug started to appear after update to Git 2.24.1. Bug reporter said that Git crashed on him while running VS Code with Git Lens extension[1] I have tried to reproduce this bug with my own compiled Git with debug flags, but sadly SIGSEGV never appeared.

To me it seems like there is a problem in commit a2bb801f6a[2] which changes move_diff_queue() function. This function calls diff_tree_oid() that calls try_to_follow_renames(). In the last two functions there are no arguments checks.

Best regards, Ondřej Pohořelský

[0] https://retrace.fedoraproject.org/faf/problems/bthash/?bth=25aa7d7267ab5de548ffca337115cb68f7b65105 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1791810 [2] https://git.kernel.org/pub/scm/git/git.git/commit/?id=a2bb801f6a430f6049e5c9729a8f3bf9097d9b34

Next: Alexandr Miloslavskiy
Message 1 of 6 in “git-core: try_to_follow_renames(): git killed by SIGSEGV”
  1. Ondrej PohorelskyFeb 27, 2020
  2. Alexandr MiloslavskiyMar 6, 2020
  3. Ondrej PohorelskyMar 10, 2020
  4. SZEDER GáborMar 10, 2020
  5. Konstantin TokarevMar 10, 2020
  6. Alexandr MiloslavskiyMar 10, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.