Re: RFC: Move existing tests to a unit testing framework - Seeking Review

From: Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date: Apr 2, 2024, 06:56 UTC
Message-ID: <CA+ARAtpqD0um9bVrjRKG0DmrxVR-46uSKfDKnO+H1rUp0i+4Ww@mail.gmail.com>
In-Reply-To: <CAHCXyj0fn5_sS8FM+US-6trM+_QbCcUnLtx8=4eJdFe=rXxkQQ@mail.gmail.com>

Hi Aishwarya Narayanan,

Thank you for your proposal.

On Sat, Mar 30, 2024 at 8:08 PM Aishwarya Narayanan <aishnana.03@gmail.com> wrote:

Show 7 quoted lines

>
> This project's goal is to adapt the existing "reftable" unit tests to
> use the new unit testing framework. This conversion will assure
> codebase continuity, increase test readability and maintainability,
> and allow for the use of the new framework's additional features and
> capabilities.
>

Your project summary and the deliverables below seem to mention that you're going to work on migration of the reftable unit tests but the project title seems to be "Move existing tests to a unit testing framework'.

Just to be clear, the "Move existing tests to a unit testing framework" and the "Convert reftable unit tests to use the unit testing framework" are two different projects as clarified in the ideas page for Git [1].

If you wish to work on the reftable unit test migration, I request you to adjust the proposal to clearly clarify the same. Make sure to understand that the reftable unit tests differ from the other unit tests in their coding style. You might also want to consider them while drafting the proposal. Check the mail from Patrick[2] for more information on the same.

[1]: https://git.github.io/SoC-2024-Ideas/ [2]: https://public-inbox.org/git/ZfwnrL6Zl_lcV09y@tanuki/

-- Sivaraam