Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

From: Lars Schneider <larsxschneider@gmail.com>
Date: Aug 21, 2015, 08:08 UTC
Message-ID: <C80E3141-C247-439B-97B5-562881C127F3@gmail.com>
In-Reply-To: <xmqq37ze7y4o.fsf@gitster.dls.corp.google.com>

@Luke, Torsten, Eric, Junio: Thanks for the great feedback. I incorporated everything into "[PATCH v3] git-p4: fix faulty paths for case insensitive systems”. Is this the correct way? I have never worked with the email-patch-files before :-)

- Lars

On 20 Aug 2015, at 17:55, Junio C Hamano <gitster@pobox.com> wrote:

Show 19 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
> 
>>>> +		find . | grep TWO/file1.txt &&
>>>> +		find . | grep TWO/File2.txt &&
>>>> +		find . | grep TWO/file3.txt &&
>>> Not sure about the find | grep here either.
>> See answers above.
> 
> These are not very good tests; they will match "OTWO/file1.txto",
> too.  Besides, it is wasteful to run find three times.
> 
>        find ?* -print | sort >actual &&
>        cat >expect <<-\EOF &&
>        TWO/file1.txt
>        ...
>        EOF
> 	test_cmp expect actual
> 
> or something like that instead?