git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] Windows: Add workaround for MSYS' path conversion

From
Steffen Prohaska <prohaska@zib.de>
Date
Sep 21, 2008, 07:48 UTC
Message-ID
<C76DB1B2-D9AB-4BA1-A983-E39D156F56A6@zib.de>
In-Reply-To
<200808172235.48321.johannes.sixt@telecom.at>
On Aug 17, 2008, at 10:35 PM, Johannes Sixt wrote:
Show 16 quoted lines
> On Sonntag, 17. August 2008, Steffen Prohaska wrote:
>> MSYS' automatic path conversion causes problems when passing paths  
>> as '-D'
>> arguments to the compiler.  MSYS tries to be smart and converts  
>> absolute
>> paths to native Windows paths.  But we want the paths as we compute  
>> them in
>> the Makefile.
>
> Huh? Doesn't the Makefile compute paths like "/c/path/to/git"? We  
> certainly
> don't want to compile such paths into git that in Windows speak  
> actually
> mean "c:/path/to/git" - git is not an MSYS program and wouldn't  
> understand
> the former. Which form of conversion are you refering to?

MSYS' automatic path conversion causes problems when passing paths as defines ('-D' arguments to the compiler). MSYS tries to be smart and converts absolute paths to native Windows paths, e.g. if MSYS sees "/bin" it converts it to "c:/msysgit/bin". But we want completely unmodified paths; e.g. if we set bindir in the Makefile to "/bin", the define BINDIR shall expand to "/bin". Conversion to absolute Windows path will takes place later, during runtime.

I'll update the commit message.
	Steffen
Previous: Johannes SixtNext: Junio C Hamano
Message 13 of 16 in “prefix discovery at runtime (on Windows)”
  1. 0/7 prefix discovery at runtime (on Windows)Steffen Prohaska, Aug 17, 2008
  2. 1/7 Windows: Add workaround for MSYS' path conversionSteffen Prohaska, Aug 17, 2008
  3. 2/7 system_path(): Add prefix computation at runtime if RUNTIME_PREFIX setSteffen Prohaska, Aug 17, 2008
  4. 3/7 Refactor git_set_argv0_path() to git_extract_argv0_path()Steffen Prohaska, Aug 17, 2008
  5. 4/7 Glean libexec path from argv[0] for git-upload-pack and git-receive-pack.Steffen Prohaska, Aug 17, 2008
  6. 5/7 Add calls to git_extract_argv0_path() in programs that call git_config_*Steffen Prohaska, Aug 17, 2008
  7. 6/7 Modify setup_path() to only add git_exec_path() to PATHSteffen Prohaska, Aug 17, 2008
  8. 7/7 Windows: Revert to default paths and convert them by RUNTIME_PREFIXSteffen Prohaska, Aug 17, 2008
  9. Johannes SixtAug 17, 2008
  10. Johannes SixtAug 17, 2008
  11. Steffen ProhaskaAug 18, 2008
  12. Johannes SixtAug 17, 2008
  13. Steffen ProhaskaSep 21, 2008
  14. Junio C HamanoAug 17, 2008
  15. Junio C HamanoSep 8, 2008
  16. Johannes SchindelinSep 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.