Re: [PATCH] gitattributes documentation: link to gitignore for glob format
- From
Wincent Colaiuta <win@wincent.com>
- Date
- Sep 21, 2008, 13:00 UTC
- Message-ID
- <C4AD5305-CDD8-418D-95C8-C738A86E78E1@wincent.com>
- In-Reply-To
- <1222001031-11382-1-git-send-email-pclouds@gmail.com>
El 21/9/2008, a las 14:43, Nguyễn Thái Ngọc Duy escribió:
Show 16 quoted lines
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> > --- > Documentation/gitattributes.txt | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/Documentation/gitattributes.txt b/Documentation/ > gitattributes.txt > index 9a75257..45c11df 100644 > --- a/Documentation/gitattributes.txt > +++ b/Documentation/gitattributes.txt > @@ -21,7 +21,9 @@ Each line in `gitattributes` file is of form: > glob attr1 attr2 ... > > That is, a glob pattern followed by an attributes list, > -separated by whitespaces. When the glob pattern matches the > +separated by whitespaces. Glob pattern format is as same as
It's "whitespace", not "whitespaces". And the sentence you added has two errors:
"as same as" should be "the same as"
> +one used by `gitignore` files. Please refer to linkgit:gitignore[5] > +for more information. When the glob pattern matches the
And: "as one" should be "as the one".
And as a style point, you probably should start the sentence with "The glob pattern" rather than "Glob pattern".
Did you actually proofread this before sending it?
Cheers, Wincent