Re: git submodules and diffing

From: Sven Herzberg <sven@imendio.com>
Date: Nov 10, 2007, 00:46 UTC
Message-ID: <C3A79C8B-2953-4A9F-B0BE-78CEA375393B@imendio.com>
In-Reply-To: <1194649057-19676-1-git-send-email-jnareb@gmail.com>

Hey Jakub,

Am 09.11.2007 um 23:57 schrieb Jakub Narebski:

Show 8 quoted lines

> Sven Herzberg wrote:
>
>> When I started working with git submodules, I realized that git-diff
>> only lists the revision ids of a submodule if it has changed. I have
>> created a repository which includes a diff command for git-submodule,
>> so you can use it like "gut submodule diff <modules...>"
>>
>> I pushed my git tree at git://git.imendio.com/sven/git.git

Show 8 quoted lines

>   http://git.imendio.com/?p=sven/git.git
>
>> Feel free to look into the changes and request improvements or merge
>> it into your tree.
>
> Although having "git submodule diff" is quite nice, I'd rather have
> "git diff --recurse-submodules" (or something like that) if I want to
> get diff of submodules.

I think it's pretty nice if git-submodule is the only command that knows about submodules.

Show 10 quoted lines

> From browsing commitdiff
>   http://git.imendio.com/?p=sven/ 
> git.git;a=commitdiff;h=7fa1d4911d1ac2590ab1eccd84a7f235aca7878e
> I'd like to mention that instead of
>
>   (unset GIT_DIR && cd "$path" && git diff $flag "$sha1..HEAD")
>
> you can simply use
>
>   git --git-dir="$path" diff $flag "$sha1..HEAD"

It wasn't exactly that simple (I has to add `pwd` and "/.git") but thats for the hint. See the updated version in my repository.

Show 6 quoted lines

>> PS: Please CC me, I'm not on this list
>
> You can always read list using NNTP / news / Usenet interface at
>   nntp://news.gmane.org/gmane.comp.version-control.git
> or one of the mailing list archives, see
>   http://git.or.cz/gitwiki/GitCommunity

I know, but being CCed is a simple task and makes it even easier for me to contribute in irregular intervals.

Thank you,
   Sven