git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Makefile: set SHELL to value of SHELL_PATH

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Aug 7, 2008, 19:03 UTC
Message-ID
<BUkcoxp99ASidQD8sGQ9PR7w1MT6DXx-6v_djYMHRBKTs_wNXEO3hw@cipher.nrlssc.navy.mil>
In-Reply-To
<alpine.DEB.1.00.0808060208450.9611@pacific.mpi-cbg.de.mpi-cbg.de>
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
Johannes Schindelin wrote:
Show 9 quoted lines
> Hi,
> 
> On Tue, 5 Aug 2008, Brandon Casey wrote:
> 
>> Otherwise, should we set the SHELL variable to the configured SHELL_PATH 
>> at some point in the Makefile?
> 
> I think that would make more sense, especially since it would catch 
> wrong SHELL_PATH early.
You're right, this makes more sense.
-brandon
 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index 52c67c1..61fc86d 100644
--- a/Makefile
+++ b/Makefile
@@ -1060,6 +1060,8 @@ export TAR INSTALL DESTDIR SHELL_PATH
 
 ### Build rules
 
+SHELL = $(SHELL_PATH)
+
 all:: $(ALL_PROGRAMS) $(BUILT_INS) $(OTHER_PROGRAMS) GIT-BUILD-OPTIONS
 ifneq (,$X)
 	$(foreach p,$(patsubst %$X,%,$(filter %$X,$(ALL_PROGRAMS) $(BUILT_INS) git$X)), $(RM) '$p';)
-- 
1.5.6.2
Previous: Johannes SchindelinNext: Brandon Casey
Message 3 of 5 in “Makefile: use backticks rather than $() notation to support ancient shells”
  1. Makefile: use backticks rather than $() notation to support ancient shellsBrandon Casey, Aug 5, 2008
  2. Johannes SchindelinAug 6, 2008
  3. Makefile: set SHELL to value of SHELL_PATHBrandon Casey, Aug 7, 2008
  4. Makefile: add a target which will abort compilation with ancient shellsBrandon Casey, Aug 7, 2008
  5. Junio C HamanoAug 8, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.