RE: [PATCH 1/1] unpack-trees: skip lstat based on fsmonitor

From: Kevin Willford <kevin.willford@microsoft.com>
Date: Oct 29, 2019, 20:12 UTC
Message-ID: <BN6PR21MB078689FFE9ED95A31998F41A91610@BN6PR21MB0786.namprd21.prod.outlook.com>
In-Reply-To: <CAPYzU3NZZ-H_PWcRH_ooXzrYnRNjvF9ayX4_xeMJeMiHB=8fLg@mail.gmail.com>

Show 7 quoted lines

> On Tuesday, October 29, 2019 1:07 PM Utsav Shah <utsav@dropbox.com>
> wrote:
> 
> I'm getting the same test failures with or without
> GIT_TEST_FSMONITOR=t/t7519/fsmonitor-all and calling refresh_fsmonitor
> in tweak_fsmonitor. Could you share your patch? I'm probably messing
> something up, and I can try taking a look at fixing test cases as well.

I have the tests passing with the following commit.

https://github.com/kewillford/git/commit/3b1fdf5a4b1cd1d654b1733ce058faa4f087f75f

Things to note:
1. Not sure if fsmonitor was tested with split index so for now I removed that from the
check of entries in fsmonitor bitmap vs the number of cache entries
2. With these changes update-index was triggering the post-index-change hook with the
updated_skipworktree flag set which it wasn't before.
3. Copied the fsmonitor_last_update to the result index so the fsmonitor data will be 
carried over to the new index in unpack_trees.  This is to make sure that the next call
to git will have the fsmonitor data to use.  We found that running `git status` after any
command that ran unpack_trees (checkout, reset --hard, etc.) was very slow the first
call but and subsequent calls were fast.

I'm still testing and reviewing these changes to make sure there isn't something I have missed and that I made the right changes to the tests that were failing.

Kevin