git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Improve --patch option documentation in git-add

From
Sean Estabrooks <seanlkml@sympatico.ca>
Date
Sep 14, 2009, 13:13 UTC
Message-ID
<BLU0-SMTP18292B09CCFD873F4A6DF6AEE40@phx.gbl>
In-Reply-To
<87vdjnlywo.fsf@jondo.cante.net>

On Sun, 13 Sep 2009 17:09:11 +0300 Jari Aalto <jari.aalto@cante.net> wrote:

> An update. Thanks,
> Jari
> 
[...]
Show 13 quoted lines
>  -p::
> --patch::
> -	Similar to Interactive mode but the initial command loop is
> -	bypassed and the 'patch' subcommand is invoked using each of
> -	the specified filepatterns before exiting.
> +	Interactively choose hunks of diff between the index and the
> +	work tree and add them to the index. This gives a change to
> +	review the differences before adding modified contents to the
> +	index.
> +
> +	This effectively runs ``add --interactive``, but bypass the
> +	initial command menu and directly jumps to `patch` subcommand.
> +	See ``Interactive mode'' for details.
Jari,

It's good that you're working to make the documentation better. To me though, it seems more difficult to parse this description than the one offered by Junio in an earlier thread:

        Review the difference between the index and the work tree, and add
        modified contents to the index interactively by choosing which
        patch hunks to use.

If you don't want to just use that description verbatim, perhaps you'd consider something closer to yours, such as:

	Interactively review the differences between the index and the
	work tree and choose which hunks to add into the index.
	This effectively runs ``add --interactive``, but bypasses the
	initial command menu and jumps directly to the `patch` subcommand.
	See ``Interactive mode'' for details.

Cheers, Sean

Previous: Jari AaltoNext: Jari Aalto
Message 13 of 21 in “Documentation/git-add.txt: Explain --patch option in layman terms”
  1. Documentation/git-add.txt: Explain --patch option in layman termsJari Aalto, Aug 30, 2009
  2. Junio C HamanoAug 30, 2009
  3. Jeff KingAug 30, 2009
  4. Jari AaltoAug 30, 2009
  5. Junio C HamanoAug 30, 2009
  6. Jari AaltoAug 30, 2009
  7. Junio C HamanoAug 30, 2009
  8. Jari AaltoAug 31, 2009
  9. Junio C HamanoAug 31, 2009
  10. Improve --patch option documentation in git-addJari Aalto, Sep 13, 2009
  11. Mikael MagnussonSep 13, 2009
  12. Jari AaltoSep 13, 2009
  13. Sean EstabrooksSep 14, 2009
  14. Jari AaltoSep 15, 2009
  15. Nanako ShiraishiSep 15, 2009
  16. Jari AaltoSep 15, 2009
  17. Nanako ShiraishiSep 15, 2009
  18. Junio C HamanoAug 30, 2009
  19. Jari AaltoAug 31, 2009
  20. Junio C HamanoAug 31, 2009
  21. Jari AaltoAug 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.