Re: [GSOC RFC PATCH] builtin/repo: add path.in-worktree field

From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date: Feb 26, 2026, 21:26 UTC
Message-ID: <BEE3B56B-F8E0-43B5-95EA-8506A84CB2EA@gmail.com>
In-Reply-To: <20260226201643.5152-1-valusoutrik@gmail.com>

> I see. Very well, I was searching for something small enough to count
> as a microproject. If I may ask, can you give some directions ?

I don't think this is small enough to count as a microproject. A microproject is something simpler than that. See the microprojects page [1] for suggestions. They are more straightforward things that have more chances of being accepted quickly. And since having an accepted microproject is a mandatory step, you'll probably want it to be merged as soon as possible.

Show 7 quoted lines

> I though about doing the group key thing : 
> 
>> Use the category as key (e.g., git repo info layout would return all 
>> layout-related values)
> 
> But its already on the SoC 2026 Ideas , and I dont know if I should do
> it.

I think that this seems to be easy to do, but the reviewing process may take some time, so it would be better if you stick to a one of the selected microprojects [1].

Show 6 quoted lines

>> Something that I would question here if isn't it possible to make
>> is_inside_work_tree accept a repository as parameter and then use it
>> here.
> 
> Like change the function in setup.c ? wouldnt that break every call of 
> is_inside_work_tree ?

Yeah, but then we would need to change all the calls to it, using the_repository at first. But I really don't know, I'll leave this discussion for more experienced people.

> Yeah ... I missed that. Suppose we were adding this path.is-in-worktree
> to repo.c , then would the below test be sufficient ? 
> 1: cd .git and then checking if path.is-in-worktree is false 
> 2: cd .. and then checking if path.is-in-worktree is true

You can take a look on how `git rev-parse --is-inside-work-tree` is being tested today and use it as a base, since `git repo info path.is-inside-work-tree` would return true or false in the same situations.

[1] https://git.github.io/SoC-2024-Microprojects/