git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow pickaxe to be used via git log.

From
Sean <seanlkml@sympatico.ca>
Date
May 19, 2006, 02:56 UTC
Message-ID
<BAYC1-PASMTP07581788E7BAAC19B2A159AEA70@CEZ.ICE>
In-Reply-To
<7v4pzmn32g.fsf@assigned-by-dhcp.cox.net>

On Thu, 18 May 2006 19:47:19 -0700 Junio C Hamano <junkio@cox.net> wrote:

Show 5 quoted lines
> If that (specifically, "when passed to git log") is what you
> want, do all of that in "git log" please.  I haven't checked,
> but I suspect your changes would break git-rev-list and makes it
> disobey the options the user gives it.
>

Well, it's more general than just git log, but that's primarily where one would see it. Essentially the patch is saying that specifying both a "revs->diffopt.pickaxe" string and "revs->always_show_header" is illegal and proceeds to use pickaxe instead of the other.

Is there any place that depends on the ability to specify both a pickaxe string _and_ always_show_header? If not, it's hard to see how this patch could break anything.

Sean
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 10 in “Allow pickaxe to be used via git log.”
  1. Allow pickaxe to be used via git log.Sean, May 19, 2006
  2. Junio C HamanoMay 19, 2006
  3. SeanMay 19, 2006
  4. Junio C HamanoMay 19, 2006
  5. SeanMay 19, 2006
  6. Junio C HamanoMay 19, 2006
  7. Allow pickaxe and diff-filter options to be used by git log.Sean, May 19, 2006
  8. Junio C HamanoMay 19, 2006
  9. SeanMay 19, 2006
  10. Junio C HamanoMay 19, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.