Re: [PATCH v5 (for maint)] git-completion: fix regression in zsh support

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 10, 2011, 17:36 UTC
Message-ID: <BANLkTinRB-hUwOdZsWRFZWxUAebkFeaGVQ@mail.gmail.com>
In-Reply-To: <7vr586jwzm.fsf@alter.siamese.dyndns.org>

On Tue, May 10, 2011 at 8:17 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Right now zsh is quite broken;...
>
> Yuck--sounds like zsh as a whole is broken, but certainly you didn't mean
> that ;-)

Right: s/zsh/zsh support/

> Could you also clarify "Right now" a bit?
>
> Is "The git-completion script in contrib/ in 1.7.5 is broken for versions
> of zsh before 4.3.12" a good rewrite of the above?

Well, "right now" all versions of zsh are before 4.3.12. I also don't see the point mentioning of 1.7.5. Maybe "The git-completion script in contrib/ is quite broken".

> of zsh before 4.3.12"
> No need for resend if that is the only change required.

All right. Hopefully there won't be other changes.

-- 
Felipe Contreras