Re: What's cooking in git.git (May 2011, #13; Mon, 30)

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 30, 2011, 13:55 UTC
Message-ID: <BANLkTinLAB3XrDtgzzZGLQXRTzzMRukV2g@mail.gmail.com>
In-Reply-To: <4DE38B61.6030400@viscovery.net>

On Mon, May 30, 2011 at 14:19, Johannes Sixt <j.sixt@viscovery.net> wrote:

Show 19 quoted lines

> Am 5/30/2011 14:08, schrieb Ævar Arnfjörð Bjarmason:
>> On Mon, May 30, 2011 at 10:16, Junio C Hamano <gitster@pobox.com> wrote:
>>
>>> * ab/i18n-scripts (2011-05-21) 48 commits
>>>  (merged to 'next' on 2011-05-23 at 69164a3)
>>> [...]
>>> Rerolled.
>>> Will cook a bit longer.
>>
>> This being ready for master is waiting on Johannes Sixt's patches to
>> supply a fallback getenv() on Win32.
>>
>> Johannes, what's the status of that, and is there anything I can do to
>> help with that?
>
> I've started with something I thought would be trivial, but I early
> tripped over a pitfall where getenv is asked to look for "PATH", and it is
> expected to find "Path" when we only have the latter in the environment.
> Sigh. I think that's solvable.

Great.

> Another worry is that the home-grown getenv is not thread-safe. I think it
> does not matter today, but who knows...

Doesn't matter for git-sh-i18n--envsubst at least, but if we want to use it everywhere it might.

We could just start with git-sh-i18n--envsubst and maybe use it for other stuff later.

> Anyway, I've at most an hour of quality git time during the week, so it
> will take some time...

No problem.