git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: blame --reverse selecting wrong commit

From
Shawn Pearce <spearce@spearce.org>
Date
May 30, 2011, 03:11 UTC
Message-ID
<BANLkTimXppE9sCW8tMntbD8p5-bRVFLHmQ@mail.gmail.com>
In-Reply-To
<BANLkTimAij28ibW3DV2HaHPK5z0D-CrDHQ@mail.gmail.com>
On Sun, May 29, 2011 at 19:33, Shawn Pearce <spearce@spearce.org> wrote:
Show 5 quoted lines
> On Sun, May 29, 2011 at 19:21, Shawn Pearce <spearce@spearce.org> wrote:
>> Although blame shows Stefan Lay removed the block in commit 05fa1713,
>> this isn't what happened. It was actually removed in commit 2302a6d3
>> by Christian Halstrick. It looks like blame gets confused around this
>> section of the JGit history.

Oh. Re-reading the man page for git blame helps. It says blame shows the last revision that a line exists in, rather than the revision that removed the line. IMHO, I expected reverse to show me the revision that deleted (or replaced) that line, so I can inspect the commit message and the contents of the patch. Showing me one of the potential parents of that revision seems to be nearly useless.

Rereading commit 85af7929ee ("git-blame --reverse"), it seems you left this an "exercise for the reader"... and in the past 3 years, no reader has stepped forward to implement the exercise as a patch to blame. *sigh*

-- 
Shawn.
Previous: Shawn PearceNext: Junio C Hamano
Message 3 of 6 in “blame --reverse selecting wrong commit”
  1. Shawn PearceMay 30, 2011
  2. Shawn PearceMay 30, 2011
  3. Shawn PearceMay 30, 2011
  4. Junio C HamanoMay 30, 2011
  5. Shawn PearceMay 30, 2011
  6. Junio C HamanoMay 30, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.