git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Documentation/git-update-index.txt: Remove obsolete note

From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date
Apr 2, 2011, 08:52 UTC
Message-ID
<BANLkTi=gadRz0XXp2Jd1Jnv7hH4fbnE45Q@mail.gmail.com>
In-Reply-To
<7v7hbfj7d6.fsf@alter.siamese.dyndns.org>
On Fri, Apr 1, 2011 at 4:41 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 18 quoted lines
> Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>
>> On Wed, Mar 30, 2011 at 8:01 PM, Jakob Pfender <jpfender@elegosoft.com> wrote:
>>> 8dcf39 (Prevent bogus paths from being added to the index) introduced a
>>> check for files beginning with '.', preventing path names such as
>>> `./file`, `dir/./file` or `dir/../file` from being added. This was
>>> reflected in the man page.
>>>
>>> d089eba (setup: sanitize absolute and funny paths in get_pathspec())
>>> removed this check without reflecting the change in the man page.
>>
>> Sounds good.
>
> When I first read it, however, I thought that the "removal" meant that the
> rewrite made the code riskier by accepting nonsense, which turns out not
> to be what the author meant.  It was more like "instead of rejecting,
> accept these paths after normalizing", no?
>
Yes it's more like that.
-- 
Duy
Previous: Junio C Hamano
Message 5 of 5 in “Documentation/git-update-index.txt: Remove obsolete note”
  1. Documentation/git-update-index.txt: Remove obsolete noteJakob Pfender, Mar 30, 2011
  2. Nguyen Thai Ngoc DuyMar 31, 2011
  3. Jakob PfenderMar 31, 2011
  4. Junio C HamanoMar 31, 2011
  5. Nguyen Thai Ngoc DuyApr 2, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.