Problems with Git's "perl" userdiff driver

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 15, 2011, 18:14 UTC
Message-ID: <BANLkTi=OXznTspN-CJjM0YXfqARxL=J+Ow@mail.gmail.com>

On Wed, Dec 29, 2010 at 06:22, Junio C Hamano <gitster@pobox.com> wrote:

[better late than never]

> * jn/perl-funcname (2010-12-27) 2 commits
>  - userdiff/perl: catch BEGIN/END/... and POD as headers
>  - diff: funcname and word patterns for perl

The POD rule doesn't work properly. I suspect it has to be:

    "^=head[0-9] .*",

Instead of the current:

    "^=head[0-9] ",

Since e.g.:

    =head1 WHATEVER

Will just be shown as:

    =head1

In the diff context.

And actually it applies very badly to POD in general, since the "sub" rule will be tried first, so e.g. in Perldoc we'll often end up finding some "sub" example halfway up the file, instead of the =head1* or =item* section a few lines up.

And it looks like the regex only catches:

    sub foo {
    }

Not:

    sub foo
    {
    }