Re: [PATCH 1/1] t5601: modernize test by using test_path_is_file
- From
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
- Date
- Apr 8, 2025, 03:01 UTC
- Message-ID
- <B0D794A6-64AB-4206-A4E2-2D13E3ADC347@gmail.com>
- In-Reply-To
- <20250407195505.86-2-ayushjaiswal12123@gmail.com>
Hi!
Two things about your patch:
1. Given that you sent only a patch, you could do that without a cover letter, sending all the additional description that you want after the scissors mark (the ---);
2. Your patch is adding the entire t5601.sh file. I could compare this with the file on the next branch, where I see that you indeed changed the line 69 for using `test_path_is_file`.
I suggest you to send a v2 containing only the changes that you did to that file, instead of a patch that creates this entire file.