git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] t5601: modernize test by using test_path_is_file

From
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date
Apr 8, 2025, 03:01 UTC
Message-ID
<B0D794A6-64AB-4206-A4E2-2D13E3ADC347@gmail.com>
In-Reply-To
<20250407195505.86-2-ayushjaiswal12123@gmail.com>
Hi!
Two things about your patch:
1. Given that you sent only a patch, you could do that without a cover
   letter, sending all the additional description that you want after 
   the scissors mark (the ---);
2. Your patch is adding the entire t5601.sh file. I could compare this
   with the file on the next branch, where I see that you indeed changed
   the line 69 for using `test_path_is_file`.

I suggest you to send a v2 containing only the changes that you did to that file, instead of a patch that creates this entire file.

Previous: ayushjaiswal12123@gmail.com
Message 3 of 3 in “t5601: modernize test by using test_path_is_file”
  1. 0/1 t5601: modernize test by using test_path_is_fileayushjaiswal12123@gmail.com, Apr 7, 2025
  2. 1/1 t5601: modernize test by using test_path_is_fileayushjaiswal12123@gmail.com, Apr 7, 2025
  3. Lucas Seiki OshiroApr 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.