git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH 2/2] git-p4: fix error handling in P4Unshelve.renameBranch()

From
Baumann, Moritz <moritz.baumann@sap.com>
Date
Jul 20, 2022, 17:01 UTC
Message-ID
<AS1PR02MB8185DC4EE3C241B0F9A9234D948E9@AS1PR02MB8185.eurprd02.prod.outlook.com>
In-Reply-To
<xmqq5yjr4ux8.fsf@gitster.g>
Thank you for your criticism, I will keep it in mind and submit more detailed descriptions in the future.
> By the way, isn't this a typical time-of-check to time-of-use bug?
> Not the problem with the fix in the patch but in the original, but regardless of
> whose fault it is, it may be good to fix it (outside the topic of this patch).
Is concurrent use even meant to be supported in general? I have not done a thorough review, but judging from what I have seen so far, I highly doubt that the majority of git-p4.py was written with potential concurrency problems in mind.

Best regards, Moritz

Previous: Junio C HamanoNext: Moritz Baumann via GitGitGadget
Message 7 of 11 in “git-p4: fix two undefined variables”
  1. 0/2 git-p4: fix two undefined variablesMoritz Baumann via GitGitGadget, Jul 20, 2022
  2. 1/2 git-p4: fix typo in P4Submit.applyCommit()Moritz Baumann via GitGitGadget, Jul 20, 2022
  3. Junio C HamanoJul 20, 2022
  4. 2/2 git-p4: fix error handling in P4Unshelve.renameBranch()Moritz Baumann via GitGitGadget, Jul 20, 2022
  5. Junio C HamanoJul 20, 2022
  6. Junio C HamanoJul 20, 2022
  7. Baumann, MoritzJul 20, 2022
  8. 0/2 git-p4: fix two undefined variablesMoritz Baumann via GitGitGadget, Jul 20, 2022
  9. 1/2 git-p4: fix typo in P4Submit.applyCommit()Moritz Baumann via GitGitGadget, Jul 20, 2022
  10. 2/2 git-p4: fix error handling in P4Unshelve.renameBranch()Moritz Baumann via GitGitGadget, Jul 20, 2022
  11. Junio C HamanoJul 20, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.