RE: Git Commit Signature Encoding

From: Rene Schumacher <rene.schumacher@microsoft.com>
Date: Feb 12, 2021, 10:12 UTC
Message-ID: <AM7PR83MB043401AAFD7377B99CA1BF97EE8B9@AM7PR83MB0434.EURPRD83.prod.outlook.com>
In-Reply-To: <962853bc-9e60-968f-c64d-35757f72e8d1@gmail.com>

Hi Philippe,

thank you for the feedback. Perhaps the reason really is the gpg4win installation. I'll put together all steps I followed to set up my environment and create an issue on GitHub. Thanks for pointing me to the correct repo!

Cheers, René

-----Original Message-----
From: Philippe Blain <levraiphilippeblain@gmail.com> 
Sent: Dienstag, 9. Februar 2021 04:13
To: Rene Schumacher <Rene.Schumacher@microsoft.com>; git@vger.kernel.org
Subject: Re: Git Commit Signature Encoding

Hi René,

Le 2021-01-27 à 04:41, Rene Schumacher a écrit :

Show 28 quoted lines

> Hi Philippe,
> 
> thanks for getting back to me so quickly! And sorry for not providing all the details right away.
> 
> I'm using Git 2.30.0.windows.1 (I believe that's the latest), gpg 2.2.27 (installed via gpg4win 3.1.15), and PowerShell 7.1.1. You might have seen my second email to the list in which I described that setting the OutputEncoding in PowerShell to UTF-8 fixed at least the display of the é (and probably all other umlauts and special printable characters). The signature output from git show --show-signatur is still printing the ^M carriage return character at the end of each line:
> 
> commit 69022a47744fcb3801572ac5d14295bcab274295 (HEAD -> master)
> gpg: Signature made 26.01.2021 17:55:36 W. Europe Standard Time^M
> gpg:                using RSA key 3848D5B2A3D45419D7F564F97802B995CDB4A2EF^M
> gpg: Good signature from "René Schumacher <rene.schumacher@microsoft.com>" [ultimate]^M
> gpg:                 aka "René Schumacher <reneschu@microsoft.com>" [ultimate]^M
> Author: René Schumacher <reneschu@microsoft.com>
> Date:   Tue Jan 26 17:55:36 2021 +0100
> 
>      another commit with signature
> 
> diff --git a/file1.txt b/file1.txt
> index a7f8d9e..6ddadea 100644
> --- a/file1.txt
> +++ b/file1.txt
> @@ -1 +1,2 @@
>   bla
> +blub
> 
> Since git verify-commit does not have those carriage return characters, I'm still wondering where they might come from.
> 
> Cheers,
> René

I've tried to replicate with 2.30.0.windows.2 and gpg 2.2.27 (that comes with Git-for-Windows), and could not, neither in Git Bash, Cmd, Windows Powershell or Powershell Core 7.1.1.

Maybe if you can provide a complete reproducer with all needed steps (git init, gpg --gen-key, etc) you would get more help in the Git-for-Windows issue tracker: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgit-for-windows%2Fgit%2Fissues&data=04%7C01%7CRene.Schumacher%40microsoft.com%7C914d70147a1945878c8208d8cca89a3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637484371825641164%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=9LgP1MLTk6s7ON4bXbS1rgSvxYKw3yytBP7D4P430oU%3D&reserved=0

Cheers, Philippe.