git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] ssh: add 'ssh.keyfile' option

From
Matthias Aßhauer <mha1993@live.de>
Date
Apr 23, 2020, 18:03 UTC
Message-ID
<AM0PR04MB47715A57B110E14D6631EACDA5D30@AM0PR04MB4771.eurprd04.prod.outlook.com>
In-Reply-To
<20200423112110.45405-1-ray@ameretat.dev>
>+		switch (variant) {
>+		case VARIANT_AUTO:
>+			BUG("VARIANT_AUTO passed to push_ssh_options");

Why do we keep replicating this all over push_ssh_options? The wording very much sounds like it's a bug whenever VARIANT_AUTO gets passed to push_ssh_options, no exceptions. In that case we should probably just check for it once at the beginning of push_ssh_options instead of after almost every single if. If there are valid cases where VARIANT_AUTO gets passed to push_ssh_options we should probably clarify the wording as to what parameter combinations are and aren't valid with VARIANT_AUTO.

I've included the Sign-Offs and Acks of the commits that introduced the previous copies of this.[1][2] The previous discussion[3] on the mailing list does not seem to mention the duplication.

[1] a3f5b66f: "ssh: 'simple' variant does not support -4/-6" 2017-11-20 [2] 3fa5e0d0: "ssh: 'simple' variant does not support --port" 2017-11-20 [3] https://lore.kernel.org/git/20170913215448.84674-1-bmwill@google.com/T/#u

Best regards
Matthias Aßhauer
Previous: Raymond E. PascoNext: Junio C Hamano
Message 6 of 9 in “ssh: add 'ssh.keyfile' option”
  1. ssh: add 'ssh.keyfile' optionRaymond E. Pasco, Apr 23, 2020
  2. ssh: add 'ssh.keyfile' optionRaymond E. Pasco, Apr 23, 2020
  3. Johannes SixtApr 23, 2020
  4. Junio C HamanoApr 23, 2020
  5. Raymond E. PascoApr 24, 2020
  6. Matthias AßhauerApr 23, 2020
  7. Junio C HamanoApr 23, 2020
  8. Matthias AßhauerApr 24, 2020
  9. connect.c: clarify BUG() messages in push_ssh_optionsMatthias Aßhauer, Apr 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.