Re: [PATCHv2] git-web--browse: Add support for google chrome
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- May 19, 2010, 10:06 UTC
- Message-ID
- <AANLkTinzbHtabNuDbRRSzyy6a87JeXotiZTq4foR-iVG@mail.gmail.com>
- In-Reply-To
- <1274262692-3783-2-git-send-email-pavan.sss1991@gmail.com>
On Wed, May 19, 2010 at 11:51 AM, Pavan Kumar Sunkara <pavan.sss1991@gmail.com> wrote:
> Add support for another web browser called chrome. To > select it, the value of the browser is 'chromium'. >
Extreme nit-pick: This last sentence is a bit outdated now, isn't it? Both 'chrome' and 'chromium' should work now, right? If you decide to post another version (I'm not sure it's worth the hassle, though - this is probably in the who-cares-land), perhaps you should mention that you're adding support for Chrome AND Chromium?
-- Erik "kusma" Faye-Lund