Re: [PATCH] rebase: pass --signoff option to git am

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Dec 6, 2010, 10:41 UTC
Message-ID: <AANLkTinnn_QnBJ8AZT9ZB+ZHVRDZV0tDret=YQeyfa01@mail.gmail.com>
In-Reply-To: <AANLkTindvz=7OmYaL6AL_oAj50U9PLnRrbSpjgR92z7C@mail.gmail.com>

On Tue, Nov 30, 2010 at 9:09 AM, Giuseppe Bilotta <giuseppe.bilotta@gmail.com> wrote:

Show 13 quoted lines

> On Mon, Nov 29, 2010 at 11:57 PM, Kevin Ballard <kevin@sb.org> wrote:
>> On Nov 27, 2010, at 3:15 AM, Giuseppe Bilotta wrote:
>>
>>> This allows people (like me) that forget to sign off their commits to do
>>> a single rebase pass e.g. while preparing the patchset for submission.
>>
>> You're probably already aware, but git format-patch supports the -s/--signoff
>> flags to sign off commits as they're prepared. There's even a config var
>> you can set to make this the default (format.signoff = true).
>
> That works if you're sharing your patches with format-patch, but not
> for example when asking for a pull. Maybe I should extend the commit
> message to include this case.

For what it's worth, somebody on #git just asked how to signoff a bunch of patches. The answer was to rebase -i and sign off each one of them. This is exactly the kind of usage that my patch would simplify. Any chance of it getting merged?

-- 
Giuseppe "Oblomov" Bilotta