git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] 'diff A...B' fails with multiple merge bases

From
Sverre Rabbelier <srabbelier@gmail.com>
Date
Jul 13, 2010, 00:41 UTC
Message-ID
<AANLkTinfo1QDguIbNgOt9w9V9xuJbhrCmusfe9g8fosm@mail.gmail.com>
In-Reply-To
<7viq4k6xea.fsf@alter.siamese.dyndns.org>
Heya,
On Mon, Jul 12, 2010 at 19:25, Junio C Hamano <gitster@pobox.com> wrote:
Show 5 quoted lines
> +               if (ents != i + 2 ||
> +                   (ent[i+1].item->flags & UNINTERESTING) ||
> +                   (!ent[i].item->flags & SYMMETRIC_LEFT) ||
> +                   (ent[i+1].item->flags & SYMMETRIC_LEFT))
> +                       die("what do you mean by that?");

That's about as helpful an error message as "Your parents must hate you" or whatever it is. Can we rephrase it to tell the user what they did wrong, and how to fix it?

-- 
Cheers,

Sverre Rabbelier
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 10 in “[BUG] 'diff A...B' fails with multiple merge bases”
  1. Pickens, James EJul 10, 2010
  2. Junio C HamanoJul 12, 2010
  3. Junio C HamanoJul 13, 2010
  4. Junio C HamanoJul 13, 2010
  5. Sverre RabbelierJul 13, 2010
  6. Junio C HamanoJul 13, 2010
  7. Sverre RabbelierJul 13, 2010
  8. Junio C HamanoJul 13, 2010
  9. Sverre RabbelierJul 13, 2010
  10. Pickens, James EJul 13, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.