git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCHv2 16/16] Add missing &&'s throughout the testsuite

From
Elijah Newren <newren@gmail.com>
Date
Sep 25, 2010, 16:50 UTC
Message-ID
<AANLkTincF9qu62w1+WLcidxFAYb8iqf_Jw+ETwuy=rg9@mail.gmail.com>
In-Reply-To
<AANLkTimfvo-nUDROSKWVFzB0HdAH4MfbH+oU4AP+pRqO@mail.gmail.com>

On Fri, Sep 24, 2010 at 5:18 PM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 11 quoted lines
> On Fri, Sep 24, 2010 at 22:22, Elijah Newren <newren@gmail.com> wrote:
>>        (
>> -               unset GIT_CONFIG GIT_WORK_TREE GIT_CONFIG
>> +               unset GIT_CONFIG GIT_WORK_TREE GIT_CONFIG &&
>
> These are all bad, see c289c315c2bfcd5fde99f9e4dbb109f89e29dfce for
> why. If it's possible maybe we should have a new:
>
>    test_returns_whatever unset FOO &&
>
> To make this more self-documenting

Isn't that what test_might_fail does (even if documented as being only for git commands)?

<snip>
Thanks for all the feedback!
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 30 of 31 in “[RFC PATCHv2 00/16] Add missing &&'s in the testsuite”
  1. Elijah NewrenSep 24, 2010
  2. 01/16 t3020 (ls-files-error-unmatch): remove stray '1' from end of fileElijah Newren, Sep 24, 2010
  3. 02/16 t4017 (diff-retval): replace manual exit code check with test_expect_codeElijah Newren, Sep 24, 2010
  4. Ævar Arnfjörð BjarmasonSep 24, 2010
  5. 03/16 t1001 (read-tree-m-2way): add missing &&Elijah Newren, Sep 24, 2010
  6. Ævar Arnfjörð BjarmasonSep 24, 2010
  7. 04/16 t1002 (read-tree-m-u-2way): add missing &&Elijah Newren, Sep 24, 2010
  8. 05/16 t4002 (diff-basic): use test_might_fail for commands that might failElijah Newren, Sep 24, 2010
  9. Ævar Arnfjörð BjarmasonSep 24, 2010
  10. 06/16 t4202 (log): Replace '<git-command> || :' with test_might_failElijah Newren, Sep 24, 2010
  11. 07/16 t3600 (rm): add lots of missing &&Elijah Newren, Sep 24, 2010
  12. Ævar Arnfjörð BjarmasonSep 24, 2010
  13. 08/16 t4019 (diff-wserror): add lots of missing &&Elijah Newren, Sep 24, 2010
  14. 09/16 t4026 (color): add missing &&Elijah Newren, Sep 24, 2010
  15. Ævar Arnfjörð BjarmasonSep 24, 2010
  16. Jeff KingSep 25, 2010
  17. Jakub NarebskiSep 25, 2010
  18. 10/16 t5602 (clone-remote-exec): add missing &&Elijah Newren, Sep 24, 2010
  19. 11/16 t6016 (rev-list-graph-simplify-history): add missing &&Elijah Newren, Sep 24, 2010
  20. Ævar Arnfjörð BjarmasonSep 24, 2010
  21. 12/16 t6050 (replace): add missing &&Elijah Newren, Sep 24, 2010
  22. Ævar Arnfjörð BjarmasonSep 24, 2010
  23. 13/16 t7001 (mv): add missing &&Elijah Newren, Sep 24, 2010
  24. Ævar Arnfjörð BjarmasonSep 24, 2010
  25. 14/16 t7601 (merge-pull-config): add missing &&Elijah Newren, Sep 24, 2010
  26. 15/16 t7800 (difftool): add missing &&Elijah Newren, Sep 24, 2010
  27. Ævar Arnfjörð BjarmasonSep 24, 2010
  28. 16/16 Add missing &&'s throughout the testsuiteElijah Newren, Sep 24, 2010
  29. Ævar Arnfjörð BjarmasonSep 24, 2010
  30. Elijah NewrenSep 25, 2010
  31. Ævar Arnfjörð BjarmasonSep 25, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.