Re: [PATCH] mailinfo: parse From header more strictly when run from rebase

From: Jay Soffian <jaysoffian@gmail.com>
Date: Jun 15, 2010, 16:41 UTC
Message-ID: <AANLkTina5G9P-OkGAoia0DeJhPygRaoaiI7tXDRHgjtF@mail.gmail.com>
In-Reply-To: <7vzkyw6zo2.fsf@alter.siamese.dyndns.org>

On Tue, Jun 15, 2010 at 12:14 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

> Jay Soffian <jaysoffian@gmail.com> writes:
>
>> Given an email address of the form:
>>
>>  author@example.com <author@example.com@11B4E7C6-762E-4CF5-B2EB-3F7BD596981D>
>>
>> results in "author@example.com" being used as both the name and the
>> address. This is due to an assumption in handle_from() that the
>> first '@' denotes the address portion. The remainder of the string
>> is then assumed to be the name, which is rejected by
>> get_sane_name(), resulting in address being used for the name as
>> well.
>
> Sorry, but it is unclear from your message what problem you are trying to
> solve, what your desired outcome is, and why you think that outcome is
> desired.  The bracketed one shown above does _not_ look like a valid email
> address, so using
>
>    name = "author@example.com"
>    email = "author@example.com@11B4..."
>
> does not sound like a good thing to do to begin with.

You left out this part of my commit message:

"In practice, I've only encountered this issue when rebasing commits that were generated by git svn."

Which is exactly what I was doing. I'm rebasing commits from this repo:

http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git

The rebase operation is munging the address and transforming an author of

  user@chromium.org <user@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>

into

  user@chromium.org <user@chromium.org>

Regardless of whether the address is valid or not, rebase shouldn't munge it.

j.