Re: [PATCH] Obey p4 views when using client spec

From: Tor Arvid Lund <torarvid@gmail.com>
Date: Feb 14, 2011, 09:16 UTC
Message-ID: <AANLkTinVp3EYFX3Ow2G8dO6Zn5BEWxuYjwO8vW2yOjcF@mail.gmail.com>
In-Reply-To: <20110212215133.GA21494@mew.padd.com>

On Sat, Feb 12, 2011 at 10:51 PM, Pete Wyckoff <pw@padd.com> wrote:

Show 23 quoted lines

> ianw@vmware.com wrote on Fri, 11 Feb 2011 16:33 -0800:
>> When using the p4 client spec, this attempts to obey the client's
>> output preferences.
>>
>> For example, a view like
>>
>> //depot/foo/branch/... //client/branch/foo/...
>> //depot/bar/branch/... //client/branch/bar/...
>>
>> will result in a directory layout in the git tree of
>>
>> branch/
>> branch/foo
>> branch/bar
>>
>> p4 can do various other reordering that this change doesn't support,
>> but we should detect it and at least fail nicely.
>>
>> Signed-off-by: Ian Wienand <ianw@vmware.com>
>
> Nice, thanks for making the changes.
>
> Acked-by: Pete Wyckoff <pw@padd.com>

Good work, Ian! Thanks.

Acked-by: Tor Arvid Lund <torarvid@gmail.com>