Re: [PATCH 000/160] [PULL] Update ab/i18n (again)
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 22, 2010, 19:36 UTC
- Message-ID
- <AANLkTinMkc6nH2+tLBVym7pSSzvTEBbgiqJSD5w3G3kz@mail.gmail.com>
- In-Reply-To
- <7veiclshoe.fsf@alter.siamese.dyndns.org>
On Wed, Sep 22, 2010 at 19:26, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > >> Oops, I didn't try running "make doc". I could write a >> Documentation/git-sh-i18n.txt manpage, but it would probably be better >> to just remove the patch adding it to command-list.txt, no? > > If it is not a documented end-user level command, it shouldn't be in the > list.
Ok. I've ejected that patch out for now, and fixed a two minor bugs One NO_GETTEXT_POISON test was in the wrong patch, and I completely removed the test that checked that $GIT_ROOT/share/locale wasn't there under NO_GETTEXT=YesPlease from the series altogether.
I've updated the ab/i18n ref at GitHub, you can pull that.
> Don't you however want to help developers by describing what the > helper offers, similar to how e.g. Documentation/git-sh-setup.txt does?
Yes, but not today if that's OK. For now it's documented in po/README. But I want to move all those docs to manpages in the future. I'll submit something for that later, but not now :)