Re: [tig] Re: compilation error: undefined reference to `set_tabsize'

From: Jonas Fonseca <jonas.fonseca@gmail.com>
Date: Sep 20, 2010, 21:48 UTC
Message-ID: <AANLkTin6YnZTyfeKKoUtGvZx8rBvfYDPG98qYa0TXoW9@mail.gmail.com>
In-Reply-To: <20100920204344.GB13017@vidovic>

On Mon, Sep 20, 2010 at 16:43, Nicolas Sebrecht <nicolas.s.dev@gmx.fr> wrote:

Show 30 quoted lines

> The 20/09/10, Stefan Näwe wrote:
>> Nicolas Sebrecht <nicolas.s.dev <at> gmx.fr> writes:
>>
>> > tig don't compile anymore here:
>> >
>> >   % make
>> >   gcc   tig.o  -lncursesw  -o tig
>> >   tig.o: In function `init_display': tig.c:7113: undefined reference to
>> `set_tabsize'
>> >   collect2: ld returned 1 exit status
>> >   make: *** [tig] Error 1
>> >   %
>> >
>> > and bisected on
>> >
>> > commit f1fe753be71ef3ce5abcbb16c2a359f97e5c7e7d
>> > Author: Stefan Naewe <>
>> > Date:   Sun Sep 12 11:03:52 2010 +0200
>> >
>> >     Use function set_tabsize()
>> >
>> >     this fixes the following compile error on cygwin:
>> >     tig.c: In function `init_display':
>> >     tig.c:7112: error: invalid lvalue in assignment
>>
>> That change works for me on Cygwin, Ubuntu 10.04, Debian 5.0.6
>>
>> Maybe you should say something about your system/OS version ?
>
> Naturally. I'm running on Gentoo.

One possibility is to add a check to configure, but I don't know if you are even using that. Alternatively, I think it would also be safe to simply just delete the line in question, since tig expands all tabs to strings since quite a few releases.

-- 
Jonas Fonseca