Re: [PATCH v2] git-am: Ignore whitespace before patches

From: Jon Seymour <jon.seymour@gmail.com>
Date: Aug 11, 2010, 22:50 UTC
Message-ID: <AANLkTin2DM-q7acST-x_Oz7jU-hODy8se6sngGxTDi_9@mail.gmail.com>
In-Reply-To: <1281556645-23361-1-git-send-email-avarab@gmail.com>

On Thu, Aug 12, 2010 at 5:57 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 14 quoted lines

> Change git-am to ignore whitespace (as defined by sh's read) at the
> beginning of patches.
>
> This makes git-am work with patches downloaded from the GMail web
> interface, here's an example from a raw Gmail attachment produced with
> `hexdump -C':
>
>    20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 20  |                |
>    20 20 20 20 20 20 20 20  20 20 20 20 20 20 20 0a  |               .|
>    52 65 74 75 72 6e 2d 50  61 74 68 3a 20 3c 61 76  |Return-Path: <av|
>
> Having to tell GMail users that they must manually edit their patches
> before git-am will accept them (as this article does:
> http://evag.evn.am/git/git-and-gmail) isn't optimal.

This is a good point. Current behaviour discourages testing of patches as delivered by e-mail since the GMail user is more likely to overlook actual whitespace errors in a patch because they come to expect this usual failure.

jon.