Re: [PATCH resend] Only run aggregate-results over actual counts

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 16, 2010, 14:27 UTC
Message-ID: <AANLkTin1BQTWj7AiEuWibanhVKu6UBJmn1iKEF-DB-s9@mail.gmail.com>
In-Reply-To: <3ce03e702e005a978d3229fa74860d6529296921.1279272868.git.trast@student.ethz.ch>

On Fri, Jul 16, 2010 at 09:37, Thomas Rast <trast@student.ethz.ch> wrote:

Show 11 quoted lines

> The current make target 'aggregate-results' scanned all files matching
> test-results/t*-*.  Normally these are only the test counts (and the
> exit values, which are ignored), but with --tee the suite also dumps
> all output.  Furthermore, with --verbose t1450 contains several lines
> starting with "broken link from ..." which matches the criteria used
> by aggregate-results.sh.
>
> Rename the counts output files to *.counts, and only scan those.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> Acked-by: Sverre Rabbelier <srabbelier@gmail.com>

Acked-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Show 11 quoted lines

> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -635,7 +635,7 @@ test_done () {
>        GIT_EXIT_OK=t
>        test_results_dir="$TEST_DIRECTORY/test-results"
>        mkdir -p "$test_results_dir"
> -       test_results_path="$test_results_dir/${0%.sh}-$$"
> +       test_results_path="$test_results_dir/${0%.sh}-$$.counts"
>
>        echo "total $test_count" >> $test_results_path
>        echo "success $test_success" >> $test_results_path

For Junio: FYI this bumps into my "test-lib: Don't write test-results when HARNESS_ACTIVE" patch in flight. The fixup is trivial though.