Re: [PATCH v2] Introduce new configuation option to override committer information

From: Stephen Kelly <steveire@gmail.com>
Date: Jan 20, 2011, 15:24 UTC
Message-ID: <AANLkTin-zUbVmJ3gUsDE5+AkECoAzN2Oim4=45JrcT6o@mail.gmail.com>
In-Reply-To: <201101201352.01874.trast@student.ethz.ch>

On Thu, Jan 20, 2011 at 1:52 PM, Thomas Rast <trast@student.ethz.ch> wrote:

Show 12 quoted lines

> Stephen Kelly wrote:
>>
>> Is this patch going to become part of git, or is it in already?
>>
>> If not it will probably just get lost because there is no issue tracker.
>
> Discussion stalled without an agreement that any patch proposed is
> "good", so if it ends here it will be dropped.
>
> You could probably help getting closer to a solution by:
>
> * Not dropping Cc's all the time.  I saw this email just by chance.

Sorry. I've never used a mailing list where you have to keep everyone in the CC. I use KNode for reading and writing to mailing lists. I don't see why you can get involved in a thread from the initial mail presumably because you read the title and decide it's interesting and then miss the replies even though they have the same title.

How does it work in this case:

Title - Stephen
* Re: Title - Alice
* * Re Title - Bob
* Re Title - Charlie

If you reply to Bob, do you also add Charlie to the CC? Do you search through everyone in long threads and make sure they're all CC'd?

I'm just trying to understand the mindset/process that everyone else on this list seems to use.

FWIW there's no need to CC me on replies. I'll see it anyway :)

Show 9 quoted lines

>
> * Stating *why* this cannot be solved in any other way on the KDE
>  end.  So far you only said
>
>  > > Is it impossible to fix this on the KDE side?  I would think a
>  > > many-to-one mapping from committer identities to bugzilla account
>  > > names could be a useful thing to have in any case.
>  >
>  > I asked that before coming here, and apparently that is not possible.

I filed a bug with the KDE sysadmins asking if there was a way of configuring multiple email addresses in bugzilla. I didn't think of adding some custom keywords to the template as you suggest below.

Show 9 quoted lines

>
>  My gut feeling is that a footer line in the commit along the lines
>  of
>
>    Bugzilla-Id: Registered Name <registered.email@example.com>
>
>  would work.  I suspect others have a similar feeling.  A good case
>  why this is not a feasible solution for (presumably) border cases
>  like you would help get rid of it.

Yes, my case is a border case. This solution seems to duplicate the committer email address in concept. It also requires more work for the KDE sysadmins.

I think the better solution is to maintain a patched version of git externally. Silly as that sounds.

Show 9 quoted lines

>
> * Replying to e.g.
>
>    http://mid.gmane.org/201101111542.15185.trast@student.ethz.ch
>
>  with (ideally better) ideas of what the semantics should be.  My
>  assessment is that it either conflicts with user expectations or
>  with established git-config mechanisms of how the various files
>  override each other.

Yes, I see what you mean in you example. If git config doesn't have any cases like this already then there's no prior art and two ways forward. I don't want to bikeshed it, so if you want just pick a solution and run with it. Otherwise I'll just continue using my patched version and drop the issue here.

Thanks,

Steve.