Problem with git bundle creation
- From
Kris Shannon <kris@shannon.id.au>
- Date
- Oct 13, 2010, 01:58 UTC
- Message-ID
- <AANLkTimsMgsuiS4iT2z_ggD8t0V9xj7ezwxRHk9WgaOw@mail.gmail.com>
git clone git://github.com/freenet/fred-official.git git bundle create bad.gitbundle -1 build01194 head -2 bad.gitbundle
Problem manifested by a commit message which happens to have a hyphen in just the wrong place such that git rev-list --boundary --pretty=oneline has a line which exceeds the 1024 buffer limit that git bundle is using for reading and happens to read in the rest of the commit messsage as a boundary commit.
git bundle should probably be checking that the fgets buffer actually ends in a newline and if it doesn't then slurp in more until it does (probably discarding it in the process)