Re: Lost in Space
- From
Erick Mattos <erick.mattos@gmail.com>
- Date
- Aug 17, 2010, 22:42 UTC
- Message-ID
- <AANLkTimqfCAy6N2w_DPvu5KBe6_8L2zrS91R43LP53J4@mail.gmail.com>
- In-Reply-To
- <AANLkTikiVQCMKjftWfrKbK-K+Gv45CTunxjULGc1==Zb@mail.gmail.com>
Hi,
2010/8/7 Jonathan Nieder <jrnieder@gmail.com>
Show 34 quoted lines
> > When searching commits for a string that never occurs, the results > page looks something like this: > > projects / foo.git / search \o/ > summary | ... | tree [commit] search: [ kfjdkas ] [ ]re > first ⋅ prev ⋅ next > > Merge branch 'maint' > > Foo: a demonstration project > > Without a list of hits to compare it to, the header describing the > commit named by the hash parameter (usually HEAD) may itself look > like a hit. Add some text (“No match.”) to replace the empty > list of hits and avoid this confusion. > > While at it, remove some nearby dead code, left behind from a > simplification a few years ago (v1.5.4-rc0~276^2~4, 2007-11-01). > > Noticed-by: Erick Mattos <erick.mattos@gmail.com> > Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> > Acked-by: Jakub Narebski <jnareb@gmail.com> > --- > changes relative to v2[1]: > - better newline placement in the produced HTML. > > Erick Mattos wrote: > > > What's up to: > > > > http://thread.gmane.org/gmane.comp.version-control.git/151402/focus=151414 > > Hopefully third time’s the charm. Test reports welcome as always.
Nice to see this one in not ignored anymore!
But what about http://thread.gmane.org/gmane.comp.version-control.git/151440/ ?!?
I am personally not bothered by being ignored but ignoring the fact that without this little patch there is a test which is testing nothing and a necessary check which is not being tested is certainly not good at all.
Two lines can not be so hard to be accepted without a huge hammer and so much unpleasant yelling!
Please let's close this issue.
Regards to all